QuarkusComponentTest: fix @InjectMock inconsistency
#41305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- take into consideration method params with `@InjectMock` when marking beans as unremovable - document that `@InjectMock` is not intended as a universal replacement for the functionality provided by the Mockito JUnit extension. - also skip param injection for params annotated with `@org.mockito.Mock` so that `@SkipInject` is not needed. - fixes quarkusio#41224
Status for workflow
|
|
🙈 The PR is closed and the preview is expired. |
manovotn
added
the
triage/waiting-for-ci
|
@mkouba I think we should backport this one to 3.12. Do you agree? If so please add the label, thanks! |
|
+1 for backporting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@InjectMockwhen marking beans as unremovable@InjectMockis not intended as a universal replacement for the functionality provided by the Mockito JUnit extension.@org.mockito.Mockso that@SkipInjectis not needed.